https://bugzilla.wikimedia.org/show_bug.cgi?id=59666

--- Comment #4 from Nik Everett <neverett+bugzi...@wikimedia.org> ---
OK!  I had a look at it.


1.  "There is a page called 'Foo'" comes from Title::newFromText( $term
)->isKnown().  We certainly shouldn't provide a suggestion in that case.
2.  It is still possible for CirrusSearch or LuceneSearch to provide a great
match even though the text isn't known.  Try searching for "pickett charge" or
even "main pages".  The top result is obviously good enough for it not to be
worth showing a suggestion but cirrus does it any way.

I think #1 we should fix in core.
#2 we should probably do in Cirrus because it knows more about how it
highlights.

I'll do both.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to