https://bugzilla.wikimedia.org/show_bug.cgi?id=59780

Brad Jorsch <bjor...@wikimedia.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aarcos.w...@gmail.com,
                   |                            |bawolff...@gmail.com,
                   |                            |bjor...@wikimedia.org,
                   |                            |fflo...@wikimedia.org,
                   |                            |gti...@wikimedia.org,
                   |                            |jger...@wikimedia.org,
                   |                            |mtrac...@member.fsf.org
          Component|Special pages               |TimedMediaHandler
            Version|1.23-git                    |master
           Assignee|wikibugs-l@lists.wikimedia. |md...@wikimedia.org
                   |org                         |
            Product|MediaWiki                   |MediaWiki extensions
   Target Milestone|1.23.0 release              |---

--- Comment #6 from Brad Jorsch <bjor...@wikimedia.org> ---
The root of the bug is apparently that TimedMediaHandler is doing something
dumb in handlers/TextHandler/TextHandler.php: it instantiates an API module,
but subclassed to point its getDB() method at some other wiki's DB, and then
calls that API module hoping that it will be able to construct a workable Title
object when passed a namespace number that doesn't even exist on the local
wiki.

Why in the world didn't they just make the appropriate database query
themselves? That would've been a whole lot more straightforward than this hacky
mess.

git blame blames Jan Gerber for introducing this code in Gerrit change 16885,
so CCing him on this bug report.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to