Web browser: ---
            Bug ID: 59889
           Summary: Clean up custom footer.html.tmpl and adapt upstream's
                    included subpages structure (blocks "saved reports" in
           Product: Wikimedia
           Version: wmf-deployment
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: Unprioritized
         Component: Bugzilla
    Classification: Unclassified
   Mobile Platform: ---

Initially I was looking at /template/en/custom/global/user-links.html.tmpl and
curious why there is no upstream equivalent.

Our custom /template/en/custom/global/footer.html.tmpl is in use.
It defines the entire left toolbar (and the footer).
It processes the following custom files:
* /template/en/custom/global/user-links.html.tmpl
* /template/en/custom/global/nav-links.html.tmpl
* /template/en/custom/global/search-links.html.tmpl

In upstream code,
/template/en/default/global/footer.html.tmpl processes 
* /template/en/default/global/useful-links.html.tmpl 
which in turn processes
* * /template/en/default/global/common-links.html.tmpl

However, as upstream /template/en/default/global/footer.html.tmpl is the only
file calling [% PROCESS "global/useful-links.html.tmpl" %], but as we have
replaced upstream footer.html.tmpl by our custom
/template/en/custom/global/footer.html.tmpl, this stuff is never called, so we
won't see a "Saved Reports" item in the left pane in Bugzilla 4.4 once we have
upgraded from 4.2 to 4.4, as <li id="reports-saved"> is defined in

We should either port, or (preferably) adapt the upstream structure to minimize
the diff here, get new functionality, and improve maintainability.

You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
Wikibugs-l mailing list

Reply via email to