https://bugzilla.wikimedia.org/show_bug.cgi?id=22315

           Summary: hook SpecialRecentChangesQuery should pass
                    $query_options ; and respect return value
           Product: MediaWiki
           Version: 1.16-svn
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: Recent changes
        AssignedTo: wikibugs-l@lists.wikimedia.org
        ReportedBy: m...@tgries.de


Created an attachment (id=7047)
 --> (https://bugzilla.wikimedia.org/attachment.cgi?id=7047)
diff patch

In SpecialRecentChangesQuery function doMainQuery hook parameters should also
pass $query_options to enable external modification such as 'group by
rc_namespace, rc_title'

wfRunHooks('SpecialRecentChangesQuery', array( &$conds, &$tables, &$join_conds,
$opts ) );

 ==>

wfRunHooks('SpecialRecentChangesQuery', array( &$conds, &$tables, &$join_conds,
$opts, &$query_options ) );

The hook call lacks also checking the return value (a false return value should
skip/abort further processing in case the extension took over processing).

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to