https://bugzilla.wikimedia.org/show_bug.cgi?id=60082
Web browser: ---
Bug ID: 60082
Summary: jenkins +2ing on planet change
Product: Wikimedia
Version: wmf-deployment
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: Unprioritized
Component: Continuous integration
Assignee: [email protected]
Reporter: [email protected]
CC: [email protected], [email protected],
[email protected]
Classification: Unclassified
Mobile Platform: ---
on https://gerrit.wikimedia.org/r/#/c/107376/3
a planet change that touches an erb template, you can see
how jenkins verifies the change, Verified+1
then I do a Code-Review+2 on it and I'm getting "Needs verified" instead of a
merge. apparently because i just got a +1 Verified from jenkins but not a +2.
is this intended? then I'd have to hit manual Verified+2 as a human here to
merge
--
03:13 < hashar> how the hell doesn't it not vote +2
03:13 < mutante> yea, that is the question:) not the planet change itself at
all
03:17 < hashar> if you could fill a bug about it, that would be nice :-]
this is that bug now
--
So after thinking about it, is this because NemoBis has created the change and
he is not on that "trusted user" regex? I remember we had something similar or
even the exact same thing before with a change made by odder. And in the end
odder has been added to a regex. How would we handle those if that's what it
is?
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
