https://bugzilla.wikimedia.org/show_bug.cgi?id=60152

       Web browser: ---
            Bug ID: 60152
           Summary: Flow: avoiding cache bugs
           Product: MediaWiki extensions
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: Unprioritized
         Component: Flow
          Assignee: wikibugs-l@lists.wikimedia.org
          Reporter: sp...@wikimedia.org
                CC: agarr...@wikimedia.org, ebernhard...@wikimedia.org,
                    oke...@wikimedia.org, pandiculat...@gmail.com,
                    sp...@wikimedia.org, tc...@wikimedia.org
    Classification: Unclassified
   Mobile Platform: ---

bug 59884 was caused by the typo:

  $pathKey = wfForeignMemcKey( 'flow', '', 'tree', 'rootpath',
$descendant->getHex() );
    $cacheKeys[$descendant->getHex()] = wfForeignMemcKey( 'flow', 'tree',
'rootpath', $descendant->getHex() );

The initial conclusion was
* write caching tests that would fail in this case with "Item should be in
cache".

But we could avoid the bug by: 
* eliminate typo by using a constant for the cache key.
**  add a class method to generate the cache key.
***   have a high-level class implement cacheThis => true

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to