https://bugzilla.wikimedia.org/show_bug.cgi?id=60077

Bartosz Dziewoński <matma....@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |krinklem...@gmail.com,
                   |                            |matma....@gmail.com,
                   |                            |roan.katt...@gmail.com,
                   |                            |tpars...@wikimedia.org
          Component|ApiSandbox                  |ResourceLoader
            Version|master                      |1.23-git
            Product|MediaWiki extensions        |MediaWiki

--- Comment #4 from Bartosz Dziewoński <matma....@gmail.com> ---
This actually looks like a core CSSMin bug to me: the url() value is not
recognized and thus not processed as it should be (fixing the patch).


For the record, one of the problematic rules is below:

.ui-widget-content { border: 1px solid #aaaaaa/*{borderColorContent}*/;
background: #ffffff/*{bgColorContent}*/
url(images/ui-bg_flat_75_ffffff_40x100.png)/*{bgImgUrlContent}*/
50%/*{bgContentXPos}*/ 50%/*{bgContentYPos}*/ repeat-x/*{bgContentRepeat}*/;
color: #222222/*{fcContent}*/; }


The braces in comments make this regex from CSSMin.php not match:

const URL_REGEX =
'url\(\s*[\'"]?(?P<file>[^\?\)\'"]*?)(?P<query>\?[^\)\'"]*?|)[\'"]?\s*\)';
$pattern = '/(?:^|[;{])\K[^;{}]*' . CSSMin::URL_REGEX . '[^;}]*(?=[;}]|$)/';


Not sure if we want to contort this regex even further to support this…
comments, anyone?

Probably caused by https://gerrit.wikimedia.org/r/#/c/94511/ .

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to