https://bugzilla.wikimedia.org/show_bug.cgi?id=25000
Kunal Mehta (Legoktm) <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #31 from Kunal Mehta (Legoktm) <[email protected]> --- Some review notes: SpecialOverrideThrottle.php: * No logging * Should use a different userright instead of noratelimit * "The exemption was applied." isn't very friendly, it should probably give some links to somewhere. * Links like [[Special:OverrideThrottle/127.0.0.1]] should work, and the special page should show past log entries for those IPs * Need some kind of checking if a restriction is already applied, and whether it should be replaced rather than duplicated. ThrottleOverrideHooks::onPingLimiter: * has an assert in it, it should throw an exception or something instead. * You can check that $user->isAnon() before falling back to the main RequestContext * $cond doesn't have to be wrapped in a makeList, it already does that internally Needs some kind of interface to remove exemptions. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
