Kunal Mehta (Legoktm) <> changed:

           What    |Removed                     |Added
                 CC|                            |

--- Comment #31 from Kunal Mehta (Legoktm) <> ---
Some review notes:

* No logging
* Should use a different userright instead of noratelimit
* "The exemption was applied." isn't very friendly, it should probably give
some links to somewhere.
* Links like [[Special:OverrideThrottle/]] should work, and the
special page should show past log entries for those IPs
* Need some kind of checking if a restriction is already applied, and whether
it should be replaced rather than duplicated.

* has an assert in it, it should throw an exception or something instead.
* You can check that $user->isAnon() before falling back to the main
* $cond doesn't have to be wrapped in a makeList, it already does that

Needs some kind of interface to remove exemptions.

You are receiving this mail because:
You are on the CC list for the bug.
Wikibugs-l mailing list

Reply via email to