https://bugzilla.wikimedia.org/show_bug.cgi?id=60418

       Web browser: ---
            Bug ID: 60418
           Summary: Flow: fatal error with
                    Flow\SpamFilter\AbuseFilter::__construct() when CI
                    runs doMaintenance.php
           Product: MediaWiki extensions
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: Unprioritized
         Component: Flow
          Assignee: wikibugs-l@lists.wikimedia.org
          Reporter: sp...@wikimedia.org
                CC: ebernhard...@wikimedia.org, oke...@wikimedia.org,
                    pandiculat...@gmail.com, sp...@wikimedia.org
    Classification: Unclassified
   Mobile Platform: ---

I noticed in deployment-bastion:/data/project/logs/fatal.log three failures in
the last hour: 25-Jan-2014 06:02:02, 06:32:02 and 7:02:01 in Flow's SpamFilter
setup, e.g.:

[25-Jan-2014 07:02:01] Catchable fatal error: Argument 1 passed to
Flow\SpamFilter\AbuseFilter::__construct() must be an instance of User, null
given, called in
/data/project/apache/common-local/php-master/extensions/Flow/container.php on
line 432 and defined at
/data/project/apache/common-local/php-master/extensions/Flow/includes/SpamFilter/AbuseFilter.php
on line 25

these aren't from the beta labs, they are on deployment-jobrunner08. I suspect
they are occurring when our Continuous Infrastructure tries to set up an MW
environment, but I'm not sure why it didn't happen earlier.  The code is 
  $c['user'] = $GLOBALS['wgUser'];
so maybe there is no wgUser when running a maintenance script.  Code could
check for this, or avoid setting up a controller.abusefilter when running
maintenance scripts.

The most recent backtrace in fatal.log is

[25-Jan-2014 07:02:01] Catchable fatal error: Argument 1 passed to
Flow\SpamFilter\AbuseFilter::__construct() must be an instance of User, null
given, called in
/data/project/apache/common-local/php-master/extensions/Flow/container.php on
line 432 and defined at
/data/project/apache/common-local/php-master/extensions/Flow/includes/SpamFilter/AbuseFilter.php
on line 25
Server: deployment-jobrunner08
URL: http://[unknown-host]
Backtrace:
#0
/data/project/apache/common-local/php-master/extensions/Flow/includes/SpamFilter/AbuseFilter.php(25):
Flow\SpamFilter\AbuseFilter::__construct()
#1
/data/project/apache/common-local/php-master/extensions/Flow/container.php(432):
Flow\SpamFilter\AbuseFilter->__construct(NULL, 'flow')
#2
/data/project/apache/common-local/php-master/extensions/Flow/vendor/Pimple.php(122):
{closure}(Object(Flow\Container))
#3
/data/project/apache/common-local/php-master/extensions/Flow/vendor/Pimple.php(83):
{closure}(Object(Flow\Container))
#4
/data/project/apache/common-local/php-master/extensions/Flow/includes/Container.php(31):
Pimple->offsetGet('controller.abus...')
#5 /data/project/apache/common-local/php-master/extensions/Flow/Hooks.php(23):
Flow\Container::get('controller.abus...')
#6 [internal function]: FlowHooks::initFlowExtension()
#7 /data/project/apache/common-local/php-master/includes/Setup.php(599):
call_user_func('FlowHooks::init...')
#8
/data/project/apache/common-local/php-master/maintenance/doMaintenance.php(106):
require_once('/data/project/a...')
#9
/data/project/apache/common-local/php-master/maintenance/getConfiguration.php(196):
require_once('/data/project/a...')
#10 /data/project/apache/common-local/multiversion/MWScript.php(97):
require_once('/data/project/a...')
#11 {main}

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to