https://bugzilla.wikimedia.org/show_bug.cgi?id=46579

Kevin Israel (PleaseStand) <pleasest...@live.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pleasest...@live.com

--- Comment #47 from Kevin Israel (PleaseStand) <pleasest...@live.com> ---
I reviewed the patch against what I understood to be the agreed-upon sequence
and found a few issues, which I noted.

As for the sequence itself, consider for example:

wgLang = fit (fallbacks fi, en)
wgContLang = fi (fallback en)

10: DB/fit
20: CDB/fit (if DB missing)
30: DB/fi
40: CDB/fi (if DB missing)
50: DB/en
60: CDB/en (if DB missing)
70: DB
80: false (site language and all fallbacks already checked)

It doesn't seem right that if DB were created, then DB/en as a translation of
DB, that DB/en would override DB. It shouldn't be necessary to duplicate DB at
DB/fi.

So perhaps it would make sense to add a "25: DB": if DB/fi is in the sequence,
then DB would be checked immediately beforehand.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to