https://bugzilla.wikimedia.org/show_bug.cgi?id=52061

--- Comment #36 from MZMcBride <b...@mzmcbride.com> ---
(In reply to comment #31)
> 1) In comment 29, Jesús Martínez Novo made a good suggestion to more widely
> publicize the new <lines> name before it gets committed.  We almost
> inadvertently introduced a conflict with <verbatim>, I'd like some greater
> certainty that the new <lines> name proposal has been seen by a larger number
> of editors/extension authors.  A mailing list thread might be a good way to
> kick off this discussion.

Will a post to wikitech-l suffice? Or is more needed in your opinion? I can
probably handle the communication portion of this, just please be explicit with
what you would consider sufficient.

> 2) In the comments on the patch, '----' was brought up as the last remaining
> way that the current <lines> implementation differs from 'indent-pre'
> handling.

Okay, I figured out what you mean here. At [[testwiki:Bug 52061#Indent-Pre
("Preceding space")]] a "----", the wikitext equivalent of a horizontal rule
(<hr>), is not current expanded when there's a leading space.

In my opinion, this behavior (preceding space + unexpanded horizontal rule) is
a separate issue that should be filed as a separate bug report (if one doesn't
exist already) and is not a blocker to merging Gerrit change 106861. If you
feel differently, can you please elaborate? (Also, can you please search for a
relevant bug report and/or file one?)

> 3) I'd also like to review the code coverage issues a little more, to ensure
> that we're sharing code (and CSS rules) to the maximum extent possible.  This
> is to ensure that point #2 continues to hold in the future, and we don't
> accidentally introduce subtle incompatibilities by changing only one side of
> a code path.

Sure, code review is ongoing at Gerrit change 106861. If you have additional
suggestions for technical changes, feel free to leave them on Gerrit. :-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to