https://bugzilla.wikimedia.org/show_bug.cgi?id=59921

Matthew Flaschen <mflasc...@wikimedia.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mflasc...@wikimedia.org

--- Comment #5 from Matthew Flaschen <mflasc...@wikimedia.org> ---
(In reply to comment #2)
> We could use a non-secret API key for vagrant and for unit tests, though. If
> you do not object, I might appropriate the old one for that purpose.

If the code is actually connecting to Flickr's servers, it's an integration
test, not a unit test.  

A lot of the mileage (if not all) could probably be achieved by mocking the
Flickr server's response in order to test the client-side code.  After all,
it's not supposed to test Flickr's code.

I don't think UploadWizard should include a key.  However, at least the current
one is not the same one used in production.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to