https://bugzilla.wikimedia.org/show_bug.cgi?id=22463

Chad H. <innocentkil...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |innocentkil...@gmail.com

--- Comment #7 from Chad H. <innocentkil...@gmail.com> 2010-02-11 13:47:33 UTC 
---
1) $wgPoweredBy should be initialized as an empty array, then the default value
for MediaWiki can be added. Also needs documentation. This should be done in
DefaultSettings, not Setup. Rather than putting $wgStylePath in the image path,
just start with 'common/images...' (and then use $wgStylePath when generating
the URL).  As long as it's clearly documented that $wgPoweredBy images are
relative to $wgStylePath, this is fine.

2) Need a space after 'by' in the alt text.

3) I would suggest using named array keys for the URL and image parameters for
clarity. Something like:
array( 'url' => 'http://mediawiki.org', 'image' =>
'common/images/poweredby_mediawiki_88x31.png' )

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to