https://bugzilla.wikimedia.org/show_bug.cgi?id=22537

--- Comment #1 from Derk-Jan Hartman <hart...@videolan.org> 2010-02-16 00:47:25 
UTC ---
Created an attachment (id=7127)
 --> (https://bugzilla.wikimedia.org/attachment.cgi?id=7127)
fix thumbs for audio using foreignapirepo

ForeignApiFile is based on File of course.

File has createThumb()
When no error can be created this returns '' otherwise it returns
$thumb->getURL()

The problem is in transform() of ForeignApiFile, which returns 'false' when no
thumb can be found. However in the case of an audio file, this is not correct.
A thumburl should always be present, or it should render the fullsize version
from the original server. Instead of returning false, we pass the invalid
thumbUrl value to getTransform, so we get a proper ThumbnailImage returned.

There might be better ways to fix this, but I don't know enough about the File
code.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to