https://bugzilla.wikimedia.org/show_bug.cgi?id=61761

            Bug ID: 61761
           Summary: TemplateData: TemplateDataGenerator causes dirty diffs
                    by always adding optional parameter’s property
                    'required'
           Product: MediaWiki extensions
           Version: unspecified
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Unprioritized
         Component: TemplateData
          Assignee: wikibugs-l@lists.wikimedia.org
          Reporter: ltrlg...@gmail.com
                CC: jforres...@wikimedia.org, krinklem...@gmail.com,
                    tpars...@wikimedia.org
       Web browser: ---
   Mobile Platform: ---

According to the last version of spec.templatedata.json, 'required' is optional
and defaults to false.

If I have the following JSON:
{
    "params": {
        "myparam": {
            "description": "Here should be a description"
        }
    }
}

TDG will replace it (when applying without changing anything) with
{
    "params": {
        "myparam": {
            "description": "Here should be a description",
            "required": false
        }
    },
    "description": ""
}

When you’ve edited a big template documentation that didn’t have any 'required'
set, that’s really hard to read

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to