https://bugzilla.wikimedia.org/show_bug.cgi?id=61786

sp...@wikimedia.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gwi...@wikimedia.org
            Summary|Flow: image caption spills  |Flow: image wikitext
                   |outside thumbnail           |produces very different
                   |                            |HTML than in wiki pages

--- Comment #1 from sp...@wikimedia.org ---
I think this bug and the related ones in your description arise because the
HTML that Parsoid creates for [[File:Bertrand Russell.jpg|thumb|right|Long long
caption]] is very different and much less elaborate than the HTML created by
the PHP parser for the same wiki text.

Examining your Flow board post, Parsoid generates:

<figure typeof="mw:Image/Thumb" class="mw-default-size mw-halign-right">
  <a href="./File:Bertrand_Russell.jpg" title="">
    <img height="260" width="220"
       
src="//upload.wikimedia.org/wikipedia/commons/thumb/4/46/Bertrand_Russell.jpg/220px-Bertrand_Russell.jpg"
        resource="./File:Bertrand_Russell.jpg">
   </a>
  <figcaption >Long long caption</figcaption>
</figure>


But in your wiki page post, the PHP Parser calls Linker::makeImageLink() and
together they generate:

<div class="thumb tright">
  <div style="width:222px;" class="thumbinner">
    <a class="image" href="/wiki/File:Bertrand_Russell.jpg">
      <img height="260" width="220"
         
srcset="//upload.wikimedia.org/wikipedia/commons/thumb/4/46/Bertrand_Russell.jpg/330px-Bertrand_Russell.jpg
1.5x, //upload.wikimedia.org/wikipedia/commons/4/46/Bertrand_Russell.jpg 2x"
          class="thumbimage"
         
src="//upload.wikimedia.org/wikipedia/commons/thumb/4/46/Bertrand_Russell.jpg/220px-Bertrand_Russell.jpg"
          alt="">
    </a>
    <div class="thumbcaption">
      <div class="magnify">
        <a title="Enlarge" class="internal"
href="/wiki/File:Bertrand_Russell.jpg">
          <img height="11" width="15" alt=""
src="//bits.wikimedia.org/static-1.23wmf14/skins/common/images/magnify-clip.png">
        </a>
      </div>
      Long long caption
    </div>
  </div>
</div>

The missing classes and containing divs account for the bugs you filed (I think
they could be made dependants of this bug or some other tracking bug).  There
are other differences such as higher-res srcset variants, the Enlarge
magnifying glass, etc. I don't see all these in the Parsoid image tracking bug
54844 so maybe I'm misunderstanding the issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to