https://bugzilla.wikimedia.org/show_bug.cgi?id=61836

            Bug ID: 61836
           Summary: Flow: Render + commit shouldn't be squashed together
           Product: MediaWiki extensions
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: Unprioritized
         Component: Flow
          Assignee: wikibugs-l@lists.wikimedia.org
          Reporter: mmul...@wikimedia.org
                CC: ebernhard...@wikimedia.org, mpinc...@wikimedia.org,
                    pandiculat...@gmail.com, sp...@wikimedia.org
       Web browser: ---
   Mobile Platform: ---

Topic.php (and others)’ commit() will commit data to cache & start rendering
right away, before data is actually stored to dbw/cache (that’s in
WorkflowLoader.php, right after Topic.php’s commit)

We should separate commit & render; all data should first be committed, then
only rendered afterwards

Otherwise, the rendered data may not 100% accurately reflect the current state
of the data (because it has not been fully committed). E.g. when restoring a
suppressed post, the post's content will be replaced by the rendered HTML
returns from the API call, but that one contains no moderation links (because
to check if these can be displayed, some permission checks are done, which run
against the most recent permission & we have not yet saved it to cache)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to