https://bugzilla.wikimedia.org/show_bug.cgi?id=53456

--- Comment #2 from Matthew Flaschen <mflasc...@wikimedia.org> ---
It seems more direct to put a hook in updateToolbarSaveButtonState (maybe
ve.saveButton.stateChanged to match ve.saveDialog.stateChanged).  Although
sanityCheckComlplete calls updateToolbarSaveButtonState, I consider that more
of an implementation detail.  

As far as awaitHook, we basically have two choices:
* Add it as a shouldSkip before doing the non-linear tour refactoring (similar
to the VE hooks already there), further cluttering the main library.
* Have this depend on bug 53143, and implement something like
https://www.mediawiki.org/wiki/Extension:GuidedTour/Refactoring_brainstorming .
This is a decent chunk of work, but it's already in our sprint.  See the part
about the listenFor proposal on the MediaWiki.org page.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to