https://bugzilla.wikimedia.org/show_bug.cgi?id=61305
--- Comment #2 from Krinkle <[email protected]> --- Request 4: https://bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&lang=en&modules=ext.flow.base%2Cdiscussion%2Cheader%2Cmoderation&only=styles&skin=vector&* Request 15: https://bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&lang=en&modules=ext.flow.base%2Cdiscussion%2Ceditor%2Cparsoid%7Cjquery.scroll&skin=vector&version=20140220T025329Z&* Request 17: https://bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&lang=en&modules=ext.flow.editors.none&skin=vector&version=20140213T190719Z&* Request 19: https://bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&lang=en&modules=ext.flow.header&skin=vector&version=20140220T025329Z&* That is: Request 1 (<link>; load.php?only=styles; short unversioned cache): ext.flow.base (styles) ext.flow.discussion (styles) ext.flow.header (styles) Request 2 (mw.loader; long versioned cache): ext.flow.base (scripts, styles, messages) ext.flow.discussion (scripts, styles, messages) ext.flow.editor (scripts, styles, messages) ext.flow.parsoid (scripts, styles, messages) Request 3 (mw.loader; long versioned cache): ext.flow.editors.none (scripts, styles, messages) Request 4 (mw.loader; long versioned cache): ext.flow.header (scripts, styles, messages) This loads base, discussion, header styles twice. And has 2 redundant http requests. It should be possible to merge request 3 and 4 into request 2, and change the modules to not contain styles loaded by addModuleStyles in the same module as one loaded with addModules. When working on this be careful with caching. Unless Flow is not deployed anywhere other than test wikis, or only deployed for logged in users, page html is cached for 30 days. Which means load.php?modules=ext.flow.base&only=styles and mw.loader.load('ext.flow.base') should remain working for a while to come (as those are already baked in the html). -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
