https://bugzilla.wikimedia.org/show_bug.cgi?id=62068
Bug ID: 62068
Summary: ResourceLoader: Change doesn't invalidate if change
only touches a 'skinStyles' file
Product: MediaWiki
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: Unprioritized
Component: ResourceLoader
Assignee: [email protected]
Reporter: [email protected]
CC: [email protected], [email protected],
[email protected]
Blocks: 54945
Web browser: ---
Mobile Platform: ---
Applying the patch from Ie6b47f5d192953366911 in VisualEditor did not result in
a module change update.
I kept refreshing and purging but nothing happened.
Turns out the way we fetch files in #getModifiedTime is broken for
'skinStyles'.
For some reason, this method duplicates the logic to interpret the 'skinStyles'
array structure from #getStyleFiles (instead of using that method), and did so
incorrectly causing it to always end up with an empty array.
The bug is quite subtle in that the module is capable of including these files
(they're not missing from the css build), it's just that the module cache isn't
invalidated if a commit only changed files listed in that part of a module.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
