https://bugzilla.wikimedia.org/show_bug.cgi?id=61743

--- Comment #3 from Prateek Saxena <psax...@wikimedia.org> ---
(In reply to Chris Steipp from comment #2)
> I'm mostly concerned about the $contentbox portion, since that is generated 
> from user content.

We are using .text() when placing the extract in the Popup[1]. Are there any
other measures that need to be taken? The other elements are being created in
jQuery (how the code convention link explains)


> Yes, this part is fine.

Alright!


> Is there a working version of this in labs somewhere that I can test with?
> Or can you list out what dependencies this has? I'm not able to get it
> working locally.

There is a test instance[2] where the latest code lives. A couple of people
have had the same issue and I am not sure what is wrong. I'll talk to Yuvi and
resolve this. Are you using the vagrant role (popups) to set it up?

[1]
https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FPopups/2b021ef048aac6bfcbd0c1944bccc9ba2d7db040/resources%2Fext.popups.core.js#L53
[2] http://chicken.wmflabs.org/wiki/TestNavPopUps

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to