https://bugzilla.wikimedia.org/show_bug.cgi?id=46511

--- Comment #12 from Jaroslav Škarvada <jskar...@redhat.com> ---
It seems the problem with the Amazon WS load balancer was already resolved in
the GIT, but the issue with the $_SERVER['HTTPS'] seems still to be unresolved.

The problem is that $_SERVER['HTTPS'] == 'on' is used in the MediaWiki for
detections of the HTTPS protocol which is not correct according to PHP
documentation [1], citing:

---
'HTTPS'
    Set to a non-empty value if the script was queried through the HTTPS
protocol.

        Note: Note that when using ISAPI with IIS, the value will be off if the
request was not made through the HTTPS protocol. 
---

I also saw implementation where it was set to '1' instead of 'on'. So to be in
sync with the PHP documentation I think it should use:
$_SERVER['HTTPS'] != '' && $_SERVER['HTTPS'] != 'off'
instead of:
$_SERVER['HTTPS'] == 'on'

I will post the patch through Gerrit.

[1] http://www.php.net/manual/en/reserved.variables.server.php

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to