https://bugzilla.wikimedia.org/show_bug.cgi?id=62258

            Bug ID: 62258
           Summary: Sizing of `frameless` images
           Product: MediaWiki
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: Unprioritized
         Component: Parser
          Assignee: wikibugs-l@lists.wikimedia.org
          Reporter: canan...@wikimedia.org
       Web browser: ---
   Mobile Platform: ---

https://www.mediawiki.org/wiki/Help:Images#Size_and_frame says:

> An image with frame always ignores the size specification, the original image
> will be reduced if it exceeds the maximum size defined in user preferences.

However, as bug 53514 describes, the actual behavior seems to have regressed at
some point.  The code in includes/Linker.php to check the user preference for
size (which seems to be the same as the thumbnail size preference) is
unreachable.  As presently written, framed images are always rendered at their
"natural" size, *unless a height* is specified, in which case the height is
honored (and the width, if any, ignored).

It's not entirely clear what the proper fix should be.  There are three
options:

1. Leave the code as is, and update the spec on the wiki.
2. If a height is specified, honor the height *and* width (conservative, should
change few pages)
3. Implement what I think was the original idea: *always* ignore the width and
height, and limit the maximum image size with the user's thumbnail size
preference.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to