https://bugzilla.wikimedia.org/show_bug.cgi?id=62762

--- Comment #3 from Roan Kattouw <roan.katt...@gmail.com> ---
We don't use $.proxy() directly in the VE code base, instead we set ve.bind =
$.proxy; and use ve.bind().

Yes, this.keyup.bind() exists in modern browsers. It doesn't exist in older
browsers, but we don't really care because VE doesn't support browsers that old
for lots of other reasons anyway.

There are two ways we could approach this. I'll ask Krinkle which one he thinks
is best before we proceed.

#1 is to migrate uses of ve.bind( this.foo, this ); to this.foo.bind( this );
across the code base, then deprecate and later remove ve.bind(). This would be
pretty laborious.

#2 is to change ve.bind() to a wrapper that uses native .bind(). This will
change every single function binding in the entire codebase to use native bind
instantaneously.

My guess it's probably best to do #2 first, then #1 later, but I'd like Krinkle
to weigh in on this.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to