Kunal Mehta (Legoktm) <> changed:

           What    |Removed                     |Added
             Status|REOPENED                    |ASSIGNED

--- Comment #31 from Kunal Mehta (Legoktm) <> ---
(In reply to Brad Jorsch from comment #0)

> For list=flow:
> * The link returned by getHelpUrls() does not actually document this API
> module.

I had removed this earlier, but I'll make sure to add it in once the parameters
are finalized.

> * The "flowaction" parameter does not list available actions.

Removed in I73347cb3b0a8cf35881691f50e70be10d10571b8 because it's pointless.

> * Same criticisms of the "params" blob as above.

After looking through all the JS that call this, they're either options to
control the result format, like "contentFormat": "wikitext", or they're a
post-id. I'll turn this into 2-3 more parameters to the API module directly.

> * You are setting "_element" directly instead of using ApiResult's methods.

Note to self that this needs to be fixed in all implementations of
Block::renderAPI as well.

> * You should be checking the return from ApiResult's addValue method and
> properly handling failure.

From the documentation, addValue will return false if the data is too big.
We'll need some kind of continuation parameter...I'm not exactly sure how Flow
handles that internally.,n,z

You are receiving this mail because:
You are on the CC list for the bug.
Wikibugs-l mailing list

Reply via email to