https://bugzilla.wikimedia.org/show_bug.cgi?id=63620
Bug ID: 63620 Summary: MobileFrontend Selenium tests do not use page object pattern Product: Wikimedia Version: wmf-deployment Hardware: All OS: All Status: NEW Severity: normal Priority: Unprioritized Component: Quality Assurance Assignee: wikibugs-l@lists.wikimedia.org Reporter: zfili...@wikimedia.org CC: cmcma...@wikimedia.org, zfili...@wikimedia.org Web browser: --- Mobile Platform: --- Examples: on(ArticlePage).link_element(class: "edit-page", index: arg1.to_i).when_present.click https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/tests/browser/features/step_definitions/editor_ve_steps.rb#L41 -- on(ArticlePage).overlay_element.when_present.h2_element(:text => "Nearby").should be_visible https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/tests/browser/features/step_definitions/geonotahack_steps.rb#L10 -- on(ArticlePage).overlay_languages_element.when_present.button_element(class: "cancel").click https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/tests/browser/features/step_definitions/language_steps.rb#L14 -- When(/^I click on "(.*?)" in the main navigation menu$/) do |text| step 'I click on the main navigation button' on(ArticlePage).navigation_element.link_element(text: text).click end Then(/^I see a link to "(.*?)" in the main navigation menu$/) do |text| on(ArticlePage).navigation_element.link_element(text: text).should be_visible end Then(/^I do not see a link to "(.*?)" in the main navigation menu$/) do |text| on(ArticlePage).navigation_element.link_element(text: text).should_not be_visible end https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/tests/browser/features/step_definitions/mainmenu_steps.rb#L5-L16 -- Then(/^I should see at least one result in the nearby items list$/) do on(ArticlePage) do |page| page.page_list_element.when_present(20).should be_visible page.page_list_element.link_element(:css => "a.title" ).should be_visible end end When(/^I click a nearby result$/) do on(ArticlePage).page_list_element.when_present(20).link_element(:css => "a.title" ).click end Then(/^I see the page preview overlay$/) do on(ArticlePage).overlay_element.when_present(20).div_element(:class => "content").should be_visible end https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/tests/browser/features/step_definitions/nearby_steps.rb#L7-L20 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l