https://bugzilla.wikimedia.org/show_bug.cgi?id=63442

--- Comment #6 from Eduard Braun <[email protected]> ---
(In reply to Jérémie Roquet from comment #5)
> If anything is to be changed, for me it would be to make “prev”, “next” and
> “cur” usable both as first and second parameters (with the result of
> Diff/<newid>/prev syntax meaning the opposite of what it means today, ie.
> newid shown on the left and prev shown on the right).

Actually (from my side) this would be fine, too. For me the crucial point is
consistency. That is meaning (or order) of the parameters shouldn't change
regardless of what kind of parameters you pass (an ID or prev/cur/next).

Therefore it basically breaks down to these two options:
1) [[Special:Diff/right_version/left_version]]
2) [[Special:Diff/left_version/right_version]]

If only one parameter is specified both cases above would get
   [[Special:Diff/right_version]]


1) is what I initially proposed. It's advantage is that also if only one
parameter is specified, it still is the version on the right in the current
implementation. Therefore the meaning of the first parameter *never* changes.

2) is slightly more intuitive in that it normally orders versions
chronologically (since normally the older version will be shown on the left and
the newer version will be shown on the right).
However if only one parameter is specified, this will be the version that is
shown on the right therefore switching the meaning of first/second parameter.


All in all I could live with both options, but changing behavior based on
whether an ID is given or a relation like prev/cur/next is inconsistent and
seems wrong to me.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to