https://bugzilla.wikimedia.org/show_bug.cgi?id=63269

--- Comment #5 from Bawolff (Brian Wolff) <[email protected]> ---
(In reply to Nemo from comment #4)
> I submitted a patch with the obvious solution, which however forces wikis to
> update (almost) any local version of 'enotif_body' or 'helppage' message.
> 
> Note, before fbc65f8972fc08a (2011-08-19, 1.19) we used fullurl, which has
> the same assumption as canonicalurl; before b7eb28ca (bug 8846) 'helppage'
> was not used in enotif.
> 
> For now I could only think of ugly alternatives:
> * regex to fix incorrect URLs after parsing;

ewww. If we consider the current patch unacceptable, I think this is best
option.

> * somehow override the default 'helppage' passed to 'enotif_body', making it
> an interwiki link that canonicalurl can parse;

Not really an option, since we can't make assumptions about the interwiki table
of third party wikis

> * find some canonicalurl/fullurl trickery so that the magic word doesn't
> fiddle with full URLs;

Don't think that's possible. Especially not without extensions.

----

I'm supportive of the patch you submitted. I think mentioning in release notes,
and making sure WMF wikis know to change it, is probably enough.

Alternative of course would be to change the message so it doesn't like to the
help page. Why would you want to go to a wikitext tutorial from a watchlist
notification email?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to