https://bugzilla.wikimedia.org/show_bug.cgi?id=63390

Steven Walling <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|PATCH_TO_REVIEW             |RESOLVED
         Resolution|---                         |WORKSFORME
            Summary|[Regression] Vector: h2     |Vector: h2 headings inside
                   |headings inside container   |container with padding have
                   |with padding have excessive |excessive whitespace on top
                   |whitespace on top           |

--- Comment #2 from Steven Walling <[email protected]> ---
I think this is probably something where special UI elements like dialogs
should be adding/changing their own H2 styles, rather than reusing styles
intended for content pages.

Repeating Kaldari's comment on the patch:

"The 1em margin was implemented on purpose by the design team. As mentioned in
the FAQ, they wanted to significantly increase the whitespace between sections.
Unfortunately on desktop we don't have any "section" DOM element, so adding top
margin to h2s is the best way to accomplish that.

Since dialogs don't often belong to the content div, it seems like better
solutions to bug 63390 would be:

1. Move the dialog outside the content div;
2. Don't use h2s in that dialog, or...
3. Override the h2 style in that case.
Is there more than 1 dialog affected by this bug?"

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to