https://bugzilla.wikimedia.org/show_bug.cgi?id=64007
Bug ID: 64007
Summary: JobQueue::push returns void, return value is used in
code
Product: MediaWiki
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: major
Priority: Unprioritized
Component: JobQueue
Assignee: [email protected]
Reporter: [email protected]
CC: [email protected]
Web browser: ---
Mobile Platform: ---
Flags: Backport_to_Stable+, Backport_WMF+
JobQueue::push
final public function push( $jobs, $flags = 0 ) {
$this->batchPush( is_array( $jobs ) ? $jobs : array( $jobs ), $flags );
}
JobQueueGroup::push
$ok = true;
foreach ( $jobsByType as $type => $jobs ) {
if ( $this->get( $type )->push( $jobs ) ) {
JobQueueAggregator::singleton()->notifyQueueNonEmpty(
$this->wiki, $type );
} else {
$ok = false;
}
}
So $ok is always going to become false
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
