https://bugzilla.wikimedia.org/show_bug.cgi?id=64086
Bug ID: 64086 Summary: Notice: Undefined variable: file_extension_length Product: MediaWiki extensions Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: Unprioritized Component: GWToolset Assignee: wikibugs-l@lists.wikimedia.org Reporter: d_ent...@yahoo.com CC: bawolff...@gmail.com, david.hask...@europeana.eu, d_ent...@yahoo.com, mtrac...@member.fsf.org Web browser: --- Mobile Platform: --- Created attachment 15135 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15135&action=edit sample dataset the extension does not set the variable to an initial value, so that when the code reaches line 412 it has not been set. also, the test on line 408 needs to test the strlen() of the $result, which it does not. in order to see the PHP Notice, you need to have GWToolset installed in an environment that has error_reporting set to E_STRICT|E_ALL. once logged in and at Step 1: Metadata detection step 1 ------ 1. nothing to add 2. select Artwork 3. nothing to add 4. nothing to add 5. choose the attached sample dataset. step 2 ------ 1. map the following fields title identifier => dc:identifier url to the media file => europeana:object 2. press the "Preview batch" button step 3 ------ 1. click on one of the resulting files 2. notice the PHP Notice: Undefined variable: file_extension_length in /extensions/GWToolset/includes/Models/MediawikiTemplate.php on line 412 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l