https://bugzilla.wikimedia.org/show_bug.cgi?id=63299
Daniel Kinzler <daniel.kinz...@wikimedia.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |daniel.kinz...@wikimedia.de
--- Comment #2 from Daniel Kinzler <daniel.kinz...@wikimedia.de> ---
(In reply to Adrian Lang from comment #1)
> * If expected data value type does not match actual data value type, add
> error to output (for widget html)
Thinking about it, we'll need this also for wikitext output, for use on the
client. So I suggest to make "include error info" a formatter option, so we can
control whether error info is inlined in each context.
> * look up formatter based on property data type if expected data value type
> matches actual data value type
> * If no formatter found, look up formatter for actual data value type
>
> Put together: Always format value, try to give error messages if there are
> mismatches.
Furthermore, if formatting of the DataValue for some other reason fails with an
exception, the ValueSnakFormatter should catch that exception, log it (probably
using wfWarn, not wfLogWarning), and optionally include it in the return value.
In that case, use an ExceptionLocalizer to generate a human readable version of
the error.
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
