https://bugzilla.wikimedia.org/show_bug.cgi?id=4421
--- Comment #66 from Aryeh Gregor <[email protected]> 2010-04-02 19:53:24 UTC --- (In reply to comment #65) > There would need to be all sorts of red flags and warnings around the part of > the configuration/code that specifies that mapping, and if there's ever a > legitimate need to remap any extension, fixing it becomes pretty fragile. Hardcode it, not configurable. Add a comment if you're worried, saying "Do not change this or else existing files will become inaccessible". Even if you think developers will ignore the comment *and* no one else will notice in code review or testing, which seems excessively pessimistic, it will still be noticed immediately upon deployment, and fixed with minimal damage. If an end-user modifies the source code without knowing what they're doing, on the other hand, they deserve whatever happens to them. There are much more destructive things they can do to their wiki. > Mind you, it's not just JPEG that has multiple choices for filename, it's most > media types. Changing it on an existing wiki seems like it'd really screw > things up, and it's pretty easy to imagine someone trying it. It's extremely hard for me to see why anyone would decide they prefer .jpeg to .jpg (or vice versa) so much that they'd look through the source code, find the code that has the mapping, *and* ignore the comment warning them not to change it. Even if they do something so pathologically stupid, it will be caught quickly and isn't that hard to fix manually. > Regardless, the job of trying a different approach would be made easier by > getting some variant of r60772 checked in (as well as some of the other fixes > and tweaks on that branch), since I'm a little worried that there's more code > that's being checked in that glibly assumes article title==filename. The > sooner those bits are checked in, the easier it would be to maintain a branch > that implements the actual feature. No objection to checking in a preliminary version, but it wouldn't make any sense to do a schema change only to decide we actually don't need it. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
