https://bugzilla.wikimedia.org/show_bug.cgi?id=62971
--- Comment #13 from Prateek Saxena <[email protected]> --- (In reply to kipod from comment #12) > clearly, this is an error: we should look at $window.height(), not width. Fixed. > more concise, simpler and clearer (and, of course, more correct, by virtue > of using "height" instead of "width"...) Agreed on use of height, style guide to be followed - https://www.mediawiki.org/wiki/CC/JS > in case the "outer height" at the point you calculate it changes later I get the height after its rendered so it can't change > if you use the same logic of setting "right" instead of "left" in case of > flippedX, the code will become significantly simpler. Hmm. It *might* not be that simple. With calculations to adjust the size of the triangle and to acutally position it above or below the link, there will be enough calculations there as well. Thanks for the review kipod! Could you please review and/or +1 the patch on Gerrit too? -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
