https://bugzilla.wikimedia.org/show_bug.cgi?id=65343

            Bug ID: 65343
           Summary: VisualEditor: Link inspector ignores selected value
           Product: VisualEditor
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: Unprioritized
         Component: Editing Tools
          Assignee: [email protected]
          Reporter: [email protected]
                CC: [email protected], [email protected],
                    [email protected], [email protected]
            Blocks: 48789
       Web browser: ---
   Mobile Platform: ---

1. Edit some text (e.g the -> foo)
1. Edit existing link (e.g. on [[mw:VisualEditor]], link to "Parsoid")
2. Enter text that makes up part of a title (e.g. "ResourceLoade", note, the
missing "r" at the end)
3. Select "ResourceLoader" from the suggestions
   (due to a bug in our search engine, this is the second suggestion, not the
first:
   [ > ResourceLoade                                 ]
     - ResourceLoader/JavaScript Deprecations
     - ResourceLoader
     - ResourceLoader/Version 1 Design Specification

4. Observe that the suggestions close after selecting an item, and the text
field now contains "ResourceLoader". Do not press enter or click anywhere.

5. Press Save Page

Video: http://cl.ly/11431q402d3A

Expected:

* Diff shows "the -> foo", and "Parsoid -> ResourceLoader".


Actual:

* Diff shows "the -> foo".

Because:

We both selected a value from the suggestions and then blurred the inspector by
clicking "Save page". Either of those actions ought to save the value into the
model, but doing both certainly should.

There are two weird things about this:

* Changing step 4 and pressing Enter there instead of Save page, makes it save
correctly.

So it seems that we just don't save properly on selection or blurring and
require one of Escape-key, Enter-key, Back-button or focussing surface (instead
of blurring inspector / focussing anything in the main window, e.g. toolbar /
save button as well, not just surface).

* Changing step 2/3 to type "ResourceLoader" straight up, and not pressing
Enter or clicking anywhere before clicking Save page also works. 

So it seems that merely changing focus from input field to save page can be
enough to have it saved. Maybe we have an exception for onkeyup/onchange and
select is bypassing that?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to