https://bugzilla.wikimedia.org/show_bug.cgi?id=65772

            Bug ID: 65772
           Summary: update.php: Time taken is incorrect when the upgrade
                    takes 1 hour or more
           Product: MediaWiki
           Version: 1.24-git
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: trivial
          Priority: Unprioritized
         Component: Installer
          Assignee: [email protected]
          Reporter: [email protected]
       Web browser: ---
   Mobile Platform: ---

I was looking back at a change I reviewed and realized that a subsequent patch
set (commit fae8daa658c1) does not correctly report durations of 1 hour or
more. For example, if the upgrade takes 4567 seconds (1 hour 16 minutes 7
seconds), the "Done in [...]" message would include:

> var_dump((new MWTimestamp)->diff(new 
> MWTimestamp(time()-4567))->format('%i:%S'));
string(5) "16:07"

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to