https://bugzilla.wikimedia.org/show_bug.cgi?id=65831

--- Comment #4 from Daniel Kinzler <[email protected]> ---
It seems like WikiPage::commitRollback() calls WikiPage::doEditContent() with
$baseRevId set to the ID of the revision to be rolled back to, instead of the
current revision before the rollback. It's unclear what the idea behind this
is, and WikiPage::doEditContent() does not specify what exactly $baseRevId is
defined to mean, or what it is used for. In fact, it's not used at all per
default, just passed on to some hooks and Content::prepareSave, which itself
doesn't use it per default either. The revision ID recorded as the revision's
"parent ID" is *not* the one passed via $baseRevId, but the ID returned by
WikiPage::getLatest().

This is woefully underspecified. I'll write to the list and ask for
clarification.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to