https://bugzilla.wikimedia.org/show_bug.cgi?id=65849
--- Comment #3 from Chad H. <[email protected]> --- Two things jumped out at me skimming this that need fixing. 1) Since you're disabling the parser cache we end up doing a select count(*) on every render of the page. This probably isn't ok and needs some sort of caching (stash the count in memcached for some short period of time maybe?) 2) Using $wgRequest in a parser function callback won't always work as you expect. Pages can be rendered in many contexts, not just from a web request (eg: command line jobs). A clever way to get around (2) would be to make it an IncludableSpecialPage instead of a parser function (you can use $par for the existing title param). Then you could call the SpecialPage's getRequest() method and just embed the special page in a non-special one if you need. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
