https://bugzilla.wikimedia.org/show_bug.cgi?id=23240
Summary: add a name and an id to the namespace selector form in
the watchlist page
Product: MediaWiki
Version: unspecified
Platform: All
OS/Version: All
Status: NEW
Severity: enhancement
Priority: Normal
Component: Watchlist
AssignedTo: [email protected]
ReportedBy: [email protected]
Created an attachment (id=7305)
--> (https://bugzilla.wikimedia.org/attachment.cgi?id=7305)
this patch adds a name and an id attributes to the form element that allows
selecting a namespace in the watchlist page
Background (skip if you're impatient):
I tried moving a script that works on the watchlist page from en.wikipedia to
meta, but it breaks there; this is because it uses the namespace selector form,
which, having no id or name, has to be selected using its index. This works
fine on most wikis, but it's very fragile, and indeed in meta there's an extra
form before that one (a button to mark all pages as visited), which makes its
index be 1 instead of 0.
I am adding a patch that adds a name and an id to the namespace selector form,
but please bear in mind that:
1) It's my first mediawiki patch
2) I couldn't find the file browsing svn; I used the version on the docs, at
http://svn.wikimedia.org/doc/SpecialWatchlist_8php-source.html (I assume it is
up to date; for reference, the revision number is r62890 as I write this)
3) I used WinMerge to generate the patch, and I'm not sure about the
configurations. It should be ok, but please double-check
4) I don't know about mediawiki php naming conventions; I tried to guide myself
by the other entries in the SpecialWatchlist.php file
5) I also made another change that may or may not break something: I removed a
name="dummy" from the "enotif_reset" submit button. I'm not sure why it was
there, and I'm not sure the function Xml::submitButton() can be called without
its second argument, but I thought it could be something someone forgot to
remove.
Sorry for the lengthy bug.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
