https://bugzilla.wikimedia.org/show_bug.cgi?id=66088
--- Comment #3 from Brandon Black <[email protected]> --- Re: patch 137095, I tend to concur with Aaron that we don't want wf* stuff in IPSet.php (which was placed in libs/ specifically with the goal that it might be generically reusable outside of MediaWiki). We bounced around on this issue a bit during the initial review process (whether and how to suppress that warning). There is a way to do the same basic thing directly (and only block E_WARNING to boot). However, suppressing the warning adds some unfortunate overhead to the otherwise-fast match() method. I don't remember how much, I'd have to go back and benchmark it again to see. The other point of view is that it's the responsibility of the caller to sanitize the $ip argument as warranted if they don't want to get E_WARNINGs (in many cases the caller may already know a lot of constraints on $ip that make it easier, or unnecessary, to validate it explicitly). It's really quite unfortunate that PHP's inet_pton() doesn't adhere to its officially-documented behavior of simply returning false in these cases and not issuing the warning in the first place. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
