https://bugzilla.wikimedia.org/show_bug.cgi?id=66236

            Bug ID: 66236
           Summary: With logLinkClick shouldDelay true, VE starts loading
                    same-page before being forced to another page
           Product: MediaWiki extensions
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: Unprioritized
         Component: GettingStarted
          Assignee: [email protected]
          Reporter: [email protected]
                CC: [email protected], [email protected],
                    [email protected]
       Web browser: ---
   Mobile Platform: ---

Since shouldDelay true makes it use window.location.href (but the normal VE
handler is not suppressed since this is not pre-edit), it will start loading
the normal same-page VE way, then change pages anyway.

This can be fixed by just setting shouldDelay false if isViewPage is true,
since in that case the event can fire in parallel with VE setting up, without
an artificial timeout or href navigation.

This can be tested in Chromium:

1. Put a breakpoint on the window.location.href line in logLinkClick.
2. Check 'Preserve log' checked in the network panel.
3. Click a VE edit link.
3. Wait a bit, then let it proceed past the break.

With the bug, the network panel will show it loading VE resources before the
HTML page load starts.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to