https://bugzilla.wikimedia.org/show_bug.cgi?id=66324
Bug ID: 66324
Summary: fix double encoding by implicit cast from String to
Url
Product: Huggle
Version: trunk
Hardware: All
OS: All
Status: NEW
Severity: minor
Priority: Unprioritized
Component: Application
Assignee: [email protected]
Reporter: [email protected]
CC: [email protected], [email protected],
[email protected]
Web browser: ---
Mobile Platform: ---
at several locations in the code there is
> QDesktopServices::openUrl(QString(<xxx>+<yyy>));
where xxx and yyy two strings. Apart from creating a new string from a string,
openUrl only accepts a QUrl. Thus QT automatically casts the whole url-QString
to QUrl using presumably
> QUrl::QUrl ( const QString & url )
which automatically percent encode all characters (of the whole url).
On some locations there are parameters also percent encoded prior adding them
to the url which results in double encoding.
using the following in our huggle.pro prevents the implicit cast for the future
(or similiar for non-qmake)
> DEFINES += QT_NO_URL_CAST_FROM_STRING
see also https://github.com/huggle/huggle3-qt-lx/pull/68
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
