https://bugzilla.wikimedia.org/show_bug.cgi?id=66086
--- Comment #9 from Jon <[email protected]> --- Looks like we are making good progress on this bug. Thanks Florian you rock! :-) I notice phpdoc complains lots about 'No summary was found for this file'. I think for the purpose of this we should simply follow this pattern: https://gerrit.wikimedia.org/r/138489 Here is the latest dump from running `make phpdoc` after adding an ignore flag for the tests directory (see https://gerrit.wikimedia.org/r/138491) It looks like we just need to cover specials directory? Parsing /Users/jrobson/Sites/w/extensions/MobileFrontend/includes/api/ApiMobileView.php No summary was found for this file Parsing /Users/jrobson/Sites/w/extensions/MobileFrontend/includes/api/ApiParseExtender.php No summary was found for this file Parsing /Users/jrobson/Sites/w/extensions/MobileFrontend/includes/DeviceDetection.php Parsing /Users/jrobson/Sites/w/extensions/MobileFrontend/includes/diff/InlineDifferenceEngine.php No summary was found for this file Parsing /Users/jrobson/Sites/w/extensions/MobileFrontend/includes/diff/InlineDiffFormatter.php No summary was found for this file Parsing /Users/jrobson/Sites/w/extensions/MobileFrontend/includes/MobileContext.php No summary was found for this file Parsing /Users/jrobson/Sites/w/extensions/MobileFrontend/includes/MobileFormatter.php No summary was found for this file Parsing /Users/jrobson/Sites/w/extensions/MobileFrontend/includes/MobileFrontend.body.php No summary was found for this file Parsing /Users/jrobson/Sites/w/extensions/MobileFrontend/includes/MobileFrontend.hooks.php No summary was found for this file Parsing /Users/jrobson/Sites/w/extensions/MobileFrontend/includes/MobilePage.php No summary was found for this file Parsing /Users/jrobson/Sites/w/extensions/MobileFrontend/includes/MobileUserInfo.php No summary was found for this file Parsing /Users/jrobson/Sites/w/extensions/MobileFrontend/includes/modules/MFResourceLoaderModule.php No summary was found for this file Parsing /Users/jrobson/Sites/w/extensions/MobileFrontend/includes/modules/MobileSiteModule.php No summary was found for this file Parsing /Users/jrobson/Sites/w/extensions/MobileFrontend/includes/Resources.php Parsing /Users/jrobson/Sites/w/extensions/MobileFrontend/includes/skins/MinervaTemplate.php No summary was found for this file Parsing /Users/jrobson/Sites/w/extensions/MobileFrontend/includes/skins/MinervaTemplateAlpha.php No summary was found for this file Parsing /Users/jrobson/Sites/w/extensions/MobileFrontend/includes/skins/MinervaTemplateBeta.php No summary was found for this file Parsing /Users/jrobson/Sites/w/extensions/MobileFrontend/includes/skins/SkinMinerva.php No summary was found for this file Parsing /Users/jrobson/Sites/w/extensions/MobileFrontend/includes/skins/SkinMinervaAlpha.php No summary was found for this file Parsing /Users/jrobson/Sites/w/extensions/MobileFrontend/includes/skins/SkinMinervaApp.php No summary was found for this file Parsing /Users/jrobson/Sites/w/extensions/MobileFrontend/includes/skins/SkinMinervaBeta.php No summary was found for this file Parsing /Users/jrobson/Sites/w/extensions/MobileFrontend/includes/skins/UserAccountCreateMobileTemplate.php No summary was found for this file Parsing /Users/jrobson/Sites/w/extensions/MobileFrontend/includes/skins/UserLoginAndCreateTemplate.php No summary was found for this file Parsing /Users/jrobson/Sites/w/extensions/MobileFrontend/includes/skins/UserLoginMobileTemplate.php No summary was found for this file Parsing /Users/jrobson/Sites/w/extensions/MobileFrontend/includes/specials/MobileSpecialPage.php No summary was found for this file No summary for class \MobileSpecialPage No summary for property $hasDesktopVersion No summary for property $mode Argument $subPage is missing from the Docblock of executeWhenAvailable() Argument $subPage is missing from the Docblock of execute() No summary for method execute() No summary for method setHeaders() Argument $msg is missing from the Docblock of renderUnavailableBanner() No summary for method addModules() No summary for method isListed() No summary for method showPageNotFound() Parsing /Users/jrobson/Sites/w/extensions/MobileFrontend/includes/specials/MobileSpecialPageFeed.php No summary was found for this file Argument $par is missing from the Docblock of execute() No summary for method execute() Argument $ts is missing from the Docblock of renderFeedItemHtml() Argument $diffLink is missing from the Docblock of renderFeedItemHtml() Argument $username is missing from the Docblock of renderFeedItemHtml() Argument $comment is missing from the Docblock of renderFeedItemHtml() Argument $title is missing from the Docblock of renderFeedItemHtml() Argument $isAnon is missing from the Docblock of renderFeedItemHtml() Argument $bytes is missing from the Docblock of renderFeedItemHtml() Argument $isMinor is missing from the Docblock of renderFeedItemHtml() No summary for method renderFeedItemHtml() Parsing /Users/jrobson/Sites/w/extensions/MobileFrontend/includes/specials/SpecialMobileContributions.php No summary was found for this file No summary for class \SpecialMobileContributions No summary for property $specialPageName No summary for property $user No summary for property $lastDate Argument $par is missing from the Docblock of executeWhenAvailable() No summary for method executeWhenAvailable() No summary for method showContributions() No summary for method showContributionsRow() No summary for method getQueryConditions() Argument $subPage is missing from the Docblock of getDesktopUrl() No summary for method getDesktopUrl() Parsing /Users/jrobson/Sites/w/extensions/MobileFrontend/includes/specials/SpecialMobileDiff.php No summary was found for this file No summary for class \SpecialMobileDiff No summary for property $hasDesktopVersion No summary for property $revId No summary for property $rev No summary for property $prevRev No summary for property $targetTitle No summary for method __construct() Argument $id is missing from the Docblock of getRevision() No summary for method getRevision() No summary for method executeBadQuery() Argument $par is missing from the Docblock of executeWhenAvailable() No summary for method executeWhenAvailable() No summary for method showHeader() No summary for method showDiff() No summary for method showFooter() No summary for method listGroups() No summary for method getMobileUrlFromDesktop() Argument $subPage is missing from the Docblock of getDesktopUrl() No summary for method getDesktopUrl() Parsing /Users/jrobson/Sites/w/extensions/MobileFrontend/includes/specials/SpecialMobileEditor.php No summary was found for this file No summary for class \SpecialMobileEditor No summary for method __construct() Argument $subpage is missing from the Docblock of executeWhenAvailable() No summary for method executeWhenAvailable() Parsing /Users/jrobson/Sites/w/extensions/MobileFrontend/includes/specials/SpecialMobileHistory.php No summary was found for this file No summary for class \SpecialMobileHistory No summary for method __construct() No summary for method showPageNotFound() Argument $par is missing from the Docblock of executeWhenAvailable() No summary for method executeWhenAvailable() No summary for method doQuery() No summary for method showRow() Argument $ts is missing from the Docblock of getMoreButton() No summary for method getMoreButton() No summary for method showHistory() Argument $subPage is missing from the Docblock of getDesktopUrl() No summary for method getDesktopUrl() Parsing /Users/jrobson/Sites/w/extensions/MobileFrontend/includes/specials/SpecialMobileLanguages.php No summary was found for this file No summary for class \SpecialMobileLanguages No summary for property $title No summary for method __construct() Argument $pagename is missing from the Docblock of executeWhenAvailable() No summary for method executeWhenAvailable() Parsing /Users/jrobson/Sites/w/extensions/MobileFrontend/includes/specials/SpecialMobileMenu.php No summary was found for this file No summary for method __construct() Argument $par is missing from the Docblock of executeWhenAvailable() No summary for method executeWhenAvailable() Parsing /Users/jrobson/Sites/w/extensions/MobileFrontend/includes/specials/SpecialMobileNotifications.php No summary was found for this file No summary for class \SpecialMobileNotifications Argument $par is missing from the Docblock of execute() No summary for method execute() Parsing /Users/jrobson/Sites/w/extensions/MobileFrontend/includes/specials/SpecialMobileOptions.php No summary was found for this file No summary for class \SpecialMobileOptions No summary for property $returnToTitle No summary for property $subpage No summary for property $hasDesktopVersion No summary for property $options No summary for property $unstyledContent No summary for method __construct() Argument $par is missing from the Docblock of execute() No summary for method execute() No summary for method getSettingsForm() No summary for method getSiteSelector() No summary for method chooseLanguage() No summary for method submitSettingsForm() Argument $option is missing from the Docblock of getURL() Argument $fullUrl is missing from the Docblock of getURL() No summary for method getURL() Parsing /Users/jrobson/Sites/w/extensions/MobileFrontend/includes/specials/SpecialMobileUserlogin.php No summary was found for this file No summary for class \SpecialMobileUserlogin Argument $par is missing from the Docblock of execute() No summary for method execute() Parsing /Users/jrobson/Sites/w/extensions/MobileFrontend/includes/specials/SpecialMobileWatchlist.php No summary was found for this file No summary for class \SpecialMobileWatchlist No summary for property $view No summary for property $filter No summary for property $usePageImages No summary for property $optionsChanged No summary for property $fromPageTitle No summary for method __construct() No summary for method renderAnonBanner() Argument $par is missing from the Docblock of executeWhenAvailable() No summary for method executeWhenAvailable() No summary for method getWatchlistHeader() No summary for method showRecentChangesHeader() No summary for method doFeedQuery() No summary for method doListQuery() No summary for method showFeedResults() No summary for method showListResults() Argument $feed is missing from the Docblock of showResults() No summary for method showResults() Argument $feed is missing from the Docblock of showEmptyList() No summary for method showEmptyList() Argument $row is missing from the Docblock of renderThumb() No summary for method renderThumb() Argument $row is missing from the Docblock of showFeedResultRow() No summary for method showFeedResultRow() Argument $row is missing from the Docblock of showListResultRow() No summary for method showListResultRow() Argument $name is missing from the Docblock of updatePreference() Argument $value is missing from the Docblock of updatePreference() No summary for method updatePreference() Argument $comment is missing from the Docblock of formatComment() Argument $title is missing from the Docblock of formatComment() No summary for method formatComment() Parsing /Users/jrobson/Sites/w/extensions/MobileFrontend/includes/specials/SpecialMobileWebApp.php No summary was found for this file No summary for class \SpecialMobileWebApp No summary for method __construct() Argument $par is missing from the Docblock of executeWhenAvailable() No summary for method executeWhenAvailable() No summary for method generateManifest() Parsing /Users/jrobson/Sites/w/extensions/MobileFrontend/includes/specials/SpecialNearby.php No summary was found for this file No summary for class \SpecialNearby No summary for property $hasDesktopVersion No summary for method __construct() Argument $par is missing from the Docblock of executeWhenAvailable() No summary for method executeWhenAvailable() Parsing /Users/jrobson/Sites/w/extensions/MobileFrontend/includes/specials/SpecialUploads.php No summary was found for this file No summary for class \SpecialUploads No summary for method __construct() Argument $par is missing from the Docblock of executeWhenAvailable() No summary for method executeWhenAvailable() Parsing /Users/jrobson/Sites/w/extensions/MobileFrontend/includes/specials/SpecialUserProfile.php No summary was found for this file No summary for class \SpecialUserProfile No summary for property $hasDesktopVersion No summary for property $targetUser No summary for property $userInfo No summary for method __construct() No summary for method getDaysAgo() No summary for method getTalkLink() No summary for method getHtmlNoUser() No summary for method getUserFooterHtml() Argument $par is missing from the Docblock of executeWhenAvailable() No summary for method executeWhenAvailable() -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
