https://bugzilla.wikimedia.org/show_bug.cgi?id=66429
--- Comment #7 from Krinkle <[email protected]> --- Taking mwext-VisualEditor-qunit as a usecase there's a couple facts: 1) As being a repo not having the target git repo (VE) at its root, it has git:clean:false and git:wipe:true (defaults), see 'use-zuul-for-mw-ext' in jenkins-job-builder-config and confirmed on https://integration.wikimedia.org/ci/job/mwext-VisualEditor-qunit/configure (expand the Advanced sections) * [ ] Clean after checkout [_] (runs `git clean`) * [x] Wipe out workspace before build 2) Looking at an example build: https://integration.wikimedia.org/ci/job/mwext-VisualEditor-qunit/10021/consoleFull - Wiping out workspace first. - Cloning repository git://zuul.eqiad.wmnet/mediawiki/extensions/VisualEditor - /srv/deployment/integration/slave-scripts/bin/mw-core-get.sh master In that order. 3) Even if this wouldn't happen, I think it's fine to use full wipe instead of git-clean since all these run on the local system and should be able to use hardlinks during the cloning (for the extension repo), and for mwcore we use archive from a central repo /srv/ssd/gerrit/mediawiki/core.git so its' fine to wipe the workspace of the extension repo) 4) Confirmed by running mkdir ~/test; export WORKSPACE=~/test; /srv/ssd/gerrit/mediawiki/core.git master; that the central git repo is not dirty, the old files and skin directories are not in there. So then why do we have RELEASE-NOTES-1.22 and skins/Modern.php in mwext-VisualEditor-qunit workspace still? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
