https://bugzilla.wikimedia.org/show_bug.cgi?id=23339

           Summary: bogus page/user invalidations
           Product: MediaWiki extensions
           Version: any
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: major
          Priority: Normal
         Component: CentralAuth
        AssignedTo: [email protected]
        ReportedBy: [email protected]
                CC: [email protected]


CentralAuth is causing needless page/user invalidations.

Existing bad code paths:

- Title cache invalidation should be done only when email settings actually
changed

LoginForm::execute
LoginForm::processLogin
LoginForm::authenticateUserData
CentralAuthPlugin::updateUser
User::saveSettings
Title::invalidateCache

- we should invalidate user cache only when there are changes that would need
different rendering logic, not for every centralauthhooks session reload

User::getOption
User::loadOptions
User::load
User::loadFromSession
wfRunHooks
call_user_func_array
CentralAuthHooks::onUserLoadFromSession
CentralAuthHooks::initSession
User::invalidateCache

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to