https://bugzilla.wikimedia.org/show_bug.cgi?id=23367
Summary: CodeReview codecomments API module using unnecessarily
confusing parameter name
Product: MediaWiki extensions
Version: any
Platform: All
OS/Version: All
Status: NEW
Severity: normal
Priority: Normal
Component: CodeReview
AssignedTo: [email protected]
ReportedBy: [email protected]
CC: [email protected]
Sort of related to bug 23366, as far as I can see, the CodeReview codecomments
module calls the status field "revision." This is brain-dead.
From
http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/CodeReview/api/ApiCodeComments.php?revision=65186&view=markup
83 if ( isset( $this->props['revision'] ) )
84 $item['status'] = $row->cr_status;
The parameter should be called "status" for the status, surely. And the
revision parameter should store the revision number. I guess this would be a
breaking change, but I think it's a necessary one.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
