https://bugzilla.wikimedia.org/show_bug.cgi?id=62602
--- Comment #16 from Krinkle <[email protected]> --- Okay, there's tons of messages back and forth and implementation has changed many times. A fresh brain dump: 1) The startup module can't be relied upon for user specific modules. We already don't do this for the (local) 'site' and 'user' modules either for they are called directly from the page html and (for 'user') *with* a version timestamp: view-source:https://www.mediawiki.org/ <script src="//bits.wikimedia.org/www.mediawiki.org/load.php?debug=false&lang=en&modules=site&only=scripts&skin=vector&*"></script> <script src="//bits.wikimedia.org/www.mediawiki.org/load.php?debug=false&lang=en&modules=user&only=scripts&skin=vector&user=Krinkle&version=20140617T190748Z&*"></script> </body></html> 2) I'm not sure where this inline registration comes from. It looks like a hack and I forgot what that is supposed to work around. Whatever the reason is, the way it is proposed in patch set 3 of Ieb6cfe2bf9a86a4 looks wrong because it doesn't compute a module version (it passes null), which means that either it is broken or makes a request without a version in the url query, which means the request will be cached between 5 and 30 minutes and not invalidated when you want it to. 3) I'd recommend simply going for the same approach as for local 'user'. Make the <script> and <link> directly. Have a ResourceLoaderModule class that retrives the style/scrript from the foreign database and compute a valid module version (happens automatically when extending ResourceLoaderWikiModule), and generate a load.php request inside the page html to the foreign wiki including &version= in the url. That way it is cached for 30 days and yet immediately invalidated when the module changes (for the 'version' value will no longer be the same then). -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
