https://bugzilla.wikimedia.org/show_bug.cgi?id=66757

--- Comment #6 from Mark A. Hershberger <[email protected]> ---
The code that this repairs simply doesn't work in my testing.  Granted, I may
not be testing correctly, but I'd like to be shown that.

Set up a MW server that can only connect to the outside world via a proxy. 
Now, set $wgHTTPProxy so the MW can use the proxy.

Call Http::get( "http://www.google.com"; )

The call will fail because noProxy is false by default (meaning, use the
proxy!) and so the condition 

 if ( $this->proxy || !$this->noProxy ) {

will be true and setupProxy() will return without setting $this->proxy to
$wgHttpProxy.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to