https://bugzilla.wikimedia.org/show_bug.cgi?id=22967
--- Comment #18 from Arod Shatil <[email protected]> 2010-05-09 15:10:33 UTC --- intermediate report: the patch seems to work as advertised, with no ill effects so far. tested with FF, IE, (8 only - i do not have access to older versions :( ), Safari, Konqueror, Opera and google chrom. i had to change the test from (len < 250) to (len < 248) (off-by-one), although conceptually, i assume that changing it to (len <= 250) would have been the "more correct" thing to do, but practically it makes sense to use 248 - with any language there are still some single-byte chars, such as punctuation and spaces, so a total size of 249 is possible, yet one would not want to add one more 2-byte character in this case. (maybe 247 would be safer still - there *are* 3-bytes-per-char languages. i use Hebrew, so 248 works for me). i also changed the "return true;" to "return;": if the return value is unimportant, we should not use it in just one case (control characters). i also do not think the line summary.maxLength = 250; is required or desired. leaving a limit of 200 chars seems reasonable. this whole bug is about *adding* a test for no-more-than-250-bytes to the existing no-more-than-200-chars limitation. the issue/question of extending the length of summary above 200 chars should be separated from the bug associated with more-than-one-byte-per-char languages and the existing 250 bytes DB limitation. peace. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
