https://bugzilla.wikimedia.org/show_bug.cgi?id=54604

--- Comment #65 from Matthew Flaschen <mflasc...@wikimedia.org> ---
(In reply to Gabriel Wicke from comment #62)
> The .plainlinks class was normally used to mark this up, and applied to all
> links inside a content block. How does this work with classes on each link?

.plainlinks .link-https has higher specificity than .link-https, so it's easy
to disable the icon for plain links, if desired.

(In reply to Gabriel Wicke from comment #64)
> Looking at the linked CSS [1], to me it seems that the most complex rules
> are those matching on file extensions to figure out video / audio / document
> links. As those links are not that common relative to the total number of
> links I'd expect classes to be a win overall for those.
> 
> Protocol matches on the other hand are a single selector only (no need for
> upper case variants), and a large chunk of external links is neither to
> videos, audio or document files. This seems to favor keeping those matches
> in CSS to keep the document size down.

I don't really know the performance details, but that seems reasonable.  PDF
links are probably more common than audio/video, but still a minority.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to